Hacker Newsnew | past | comments | ask | show | jobs | submitlogin

Overall, very well written proxy. Just few nitpicks from browsing the code:

https://github.com/droe/sslsplit/blob/master/pxyconn.c#L991-...

there is no guarantee that a space comes after the colon. These comparisons are better off with 1 character less.

https://github.com/droe/sslsplit/blob/master/pxythrmgr.c#L12...

pthread_mutex_init can fail.



On linux, pthread_mutex_init always returns 0. But yes, according to POSIX, the function might fail (the common response is generally to assert() in this case)


On linux, pthread_mutex_init can fail and return ENOMEM.


No, it can not, at least on non-obsolete GLIBC. http://fossies.org/linux/glibc/nptl/pthread_mutex_init.c#l_4...


You should refer to the man pages not particular implementations.




Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: